cat/Purrse
Private
Public Access
1
0
Fork 0
Code Activity

Fix concurrency exception when editing loan details

Browse Source 
RemoveRange + collection replacement caused EF Core to attempt a
double-delete on amortization entries. Use Clear() on the tracked
collection instead, letting EF handle orphan deletion in a single pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Catherine Renelle
2026-02-14 17:00:47 -05:00
parent b7ef9e36ce
commit 7efeb4957b
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Purrse.Api/Services/LoanService.cs
+3 -2
View File
@@ -70,7 +70,7 @@ public class LoanService : ILoanService
var l = account.LoanDetail ?? throw new KeyNotFoundException("No loan detail found"); var l = account.LoanDetail ?? throw new KeyNotFoundException("No loan detail found");
_db.AmortizationEntries.RemoveRange(l.AmortizationEntries); l.AmortizationEntries.Clear();
l.OriginalBalance = request.OriginalBalance; l.OriginalBalance = request.OriginalBalance;
l.InterestRate = request.InterestRate; l.InterestRate = request.InterestRate;
@@ -82,7 +82,8 @@ public class LoanService : ILoanService
l.ExtraPayment = request.ExtraPayment; l.ExtraPayment = request.ExtraPayment;
var entries = GenerateAmortizationSchedule(l); var entries = GenerateAmortizationSchedule(l);
l.AmortizationEntries = entries; foreach (var entry in entries)
l.AmortizationEntries.Add(entry);
await _db.SaveChangesAsync(); await _db.SaveChangesAsync();
var schedule = entries.Select(e => new AmortizationEntryResponse(e.PaymentNumber, e.PaymentDate, e.PaymentAmount, e.PrincipalAmount, e.InterestAmount, e.EscrowAmount, e.RemainingBalance)).ToList(); var schedule = entries.Select(e => new AmortizationEntryResponse(e.PaymentNumber, e.PaymentDate, e.PaymentAmount, e.PrincipalAmount, e.InterestAmount, e.EscrowAmount, e.RemainingBalance)).ToList();